Fix Code Panel Toggle Broken on Master (Twig-specific Fix) #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epo, updating to match more recent UIkit JS and CSS updates
…st Twig PHP compiles properly; update demo config to point at assets for the time being
…templates not be inlined (aka allow Twig namespaced paths to point at these templates vs inlining the contents)
…; fix typo / formatting bug causing mustache loader to not compile base UI templates as expected
…broken on master, most likely due to internal data structure changes implemented at some point. Updates fix the issue reported in pattern-lab#761 however are unfortunately Twig specific for now until the underlying changes are identified and internally exported data structures are updated accordingly.
sghoweri
changed the title
Member
|
Since this is Twig specific I want @EvanLovely to be satisfied with it. Assigning |
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
|
Issue closed after going stale. It can be re-opened if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, see changes from lines 30 to 49: https://github.com/pattern-lab/patternlab-node/compare/feature/engine-twig-php...sghoweri:feature/engine-twig-php--fix-code-panel-in-twig?expand=1#diff-a3e7ad2ea7763bc4319b1779d5bfbc8eR30 -- unfortunately this is based off of my other open PR #902 since this specifically updates on Twig template to fix the data structure expected by the current UIkit JavaScript.
In any case, this is a partial Twig-specific fix for the collapsible code panels being broken on master, most likely due to internal data structure changes implemented at some point.
These updates fix the issue reported in #761 however are unfortunately Twig specific for now until the underlying changes are identified and internally exported data structures are updated accordingly.