Skip to content

Conversation

@bmuenzenmeyer
Copy link
Member

Summary of changes:

  • Pattern States are now assigned using the pattern key (atoms-colors), not the pattern name (colors). This change aligns with other uses of the key throughout Pattern Lab.
  • Patterns inherit the lowest common denominator pattern state of their lineage.
  • Pattern inheritance occurs only for patterns that define a pattern state themselves.

closes #203

@geoffp
Copy link
Contributor

geoffp commented Mar 9, 2016

Nice!

I am now realizing that I think we overlooked unit tests in our whitespace cleanup.

@bmuenzenmeyer
Copy link
Member Author

Right - I saw that too, in addition to eslint. It's a good bit of busy work that can be put into #241

bmuenzenmeyer pushed a commit that referenced this pull request Mar 10, 2016
Implement pattern state lowest common denominator
@bmuenzenmeyer bmuenzenmeyer merged commit baf7b94 into dev Mar 10, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the 203-patternstates-inheritance branch May 13, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement pattern state lowest common denominator

3 participants