Replacing eval with json.parse #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hey @e2tha-e I haven't liked the way I've handled this for a while - I think this is a smart addition. |
Contributor
|
Delete eval() = happy dance |
3 tasks
Member
|
Looks great! |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 23, 2016
Replacing eval with json.parse
bmuenzenmeyer
added a commit
that referenced
this pull request
Feb 23, 2016
therynamo
pushed a commit
to therynamo/patternlab-node
that referenced
this pull request
Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #250 preliminary work
Summary of changes:
@bmuenzenmeyer I had been perusing parameter_hunter.js and think it's time to get rid of the eval() statement. I think this replacement is relatively simple, and complete at the same time. Please review.