update lineage_hunter - refactor

[mateusvahl]

Target the dev branch!
Summary of changes:
I remove Closures("(function () { ... })()") since node will not export any that are not implicit with module.exports. Also removed some nested functions.

Thanks!

[bmuenzenmeyer]

Hi @Mateuspv

it looks like this optimization could be applied to other builder/ files besides list_item_hunter.js, is that correct?

[mateusvahl]

Hi @bmuenzenmeyer, Yes. You can remove the "main code" from inside the closure:
(function() {
/* main code here */
})()

[bmuenzenmeyer]

Thanks for the clarification. I'd rather see all the extraneous closures removed at once for consistencies sake. If you feel like tackling that, please do so. Else this might get prioritized a bit further down the pile.

[geoffp]

I was just researching this issue, and I agree that we should remove them all.

@Mateuspv, if you're up for doing all of them, that would be amazing, but if you don't want to, I could do it as part of a larger whitespace & indentation cleanup.

[mateusvahl]

@geoffp I'm sure when I will do it =/, so feel free to do..

[bmuenzenmeyer]

I second rolling it into #264

[bmuenzenmeyer]

Added as a todo item to #264.

Closing this.