Skip to content

fix: hogan to handlebars migration leftovers #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2022
Merged

fix: hogan to handlebars migration leftovers #1461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/uikit-workshop/src/scripts/components/panels-viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
/* eslint-disable no-param-reassign, no-unused-vars */

import Handlebars from 'handlebars';
import Handlebars from 'handlebars/dist/handlebars';
import pretty from 'pretty';
import { html, render } from 'lit-html';
import { unsafeHTML } from 'lit-html/directives/unsafe-html.js';
Expand Down Expand Up @@ -176,7 +176,7 @@ export const panelsViewer = {
// vanilla render of pattern data
template = document.getElementById(panel.templateID);
templateCompiled = Handlebars.compile(template.innerHTML);
templateRendered = templateCompiled.render(patternData);
templateRendered = templateCompiled(patternData);
const normalizedCode =
normalizeWhitespace.normalize(templateRendered);
normalizedCode.replace(/[\r\n]+/g, '\n\n');
Expand Down Expand Up @@ -305,7 +305,7 @@ export const panelsViewer = {
// render all of the panels in the base panel template
const template = document.querySelector('.pl-js-panel-template-base');
const templateCompiled = Handlebars.compile(template.innerHTML);
templateRendered = templateCompiled.render(patternData);
templateRendered = templateCompiled(patternData);

// make sure templateRendered is modified to be an HTML element
const div = document.createElement('div');
Expand Down