Skip to content

refactor(docs): optimizations #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2021
Merged

refactor(docs): optimizations #1327

merged 5 commits into from
Jun 11, 2021

Conversation

@mfranzke
Copy link
Contributor

@mfranzke mfranzke commented May 23, 2021 •
edited
Loading

Summary of changes:

  • corrected the path for copy action of the nunjucks file

Error with passthrough copy: (more in DEBUG output)
[3] > Having trouble copying './node_modules/nunjucks/browser/nunjucks-slim.js' (TemplatePassthroughManagerCopyError)
[3] > ENOENT: no such file or directory, lstat './node_modules/nunjucks/browser/nunjucks-slim.js' (Error):
[3] Error: ENOENT: no such file or directory, lstat './node_modules/nunjucks/browser/nunjucks-slim.js'

from Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts

mfranzke added 3 commits May 23, 2021 19:30
@mfranzke
refactor(docs): added dimensions to the images
c41e1e4 
for easier calculation by the browser and to prevent reflow
@mfranzke
refactor(yarn): removed unnecessary additional -- for parameters
54c1ea6 
as shown on the output / shell:
from Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts
@mfranzke
fix(docs): corrected the path for a copy action
055cc02
@mfranzke mfranzke marked this pull request as ready for review May 23, 2021 17:59
@mfranzke
chore(docs): added nunjucks dependency
100f970 
that is (now correctly) referenced within the files of the docs package
@JosefBredereck JosefBredereck merged commit 6141594 into pattern-lab:dev Jun 11, 2021
@mfranzke mfranzke deleted the refactor-docs-optimizations branch June 12, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JosefBredereck JosefBredereck JosefBredereck approved these changes

Assignees

No one assigned

Labels

released 🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfranzke @JosefBredereck