Skip to content

fix(core): ReadDocumentation throw error on older node versions #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2021
Merged

fix(core): ReadDocumentation throw error on older node versions #1295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efad4c5
fix(core): ReadDocumentation throw error on older node versions
JosefBredereck Mar 5, 2021
1a2deee
fix(core): ReadDocumentation add additional error code to ignore
JosefBredereck Mar 5, 2021
a3a2d8b
Merge branch 'dev' into fix-read-doc-throw-error
JosefBredereck Mar 24, 2021
592c609
Merge branch 'dev' into fix-read-doc-throw-error
JosefBredereck Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 60 additions & 56 deletions packages/core/src/lib/readDocumentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,70 +82,74 @@ module.exports = function(pattern, patternlab, isVariant) {

// Read Documentation for Pattern-Group
// Use this approach, since pattern lab is a pattern driven software
try {
if (pattern.patternGroup) {
const groupRelPath = pattern.relPath.split(path.sep);
const markdownFileNameGroup = path.resolve(
patternlab.config.paths.source.patterns,
groupRelPath[0] || pattern.subdir,
GROUP_DOC_PREFIX + pattern.patternGroup + FILE_EXTENSION
);
const markdownFileContentsGroup = fs.readFileSync(
markdownFileNameGroup,
'utf8'
);
const markdownObjectGroup = markdown_parser.parse(
markdownFileContentsGroup
);

if (!_.isEmpty(markdownObjectGroup)) {
pattern.patternGroupData = markdownObjectGroup;
}
} catch (err) {
// do nothing when file not found
if (err.code !== 'ENOENT') {
logger.warning(
`There was an error setting pattern group data after markdown parsing for ${path.join(
patternlab.config.paths.source.patterns,
path.parse(pattern.subdir).dir,
GROUP_DOC_PREFIX + pattern.patternGroup + FILE_EXTENSION
)}`
try {
const markdownFileNameGroup = path.resolve(
patternlab.config.paths.source.patterns,
groupRelPath[0] || pattern.subdir,
GROUP_DOC_PREFIX + pattern.patternGroup + FILE_EXTENSION
);
logger.warning(err);
const markdownFileContentsGroup = fs.readFileSync(
markdownFileNameGroup,
'utf8'
);
const markdownObjectGroup = markdown_parser.parse(
markdownFileContentsGroup
);

if (!_.isEmpty(markdownObjectGroup)) {
pattern.patternGroupData = markdownObjectGroup;
}
} catch (err) {
// do nothing when file not found
if (err.code !== 'ENOENT' && err.code !== 'ENOTDIR') {
logger.warning(
`There was an error setting pattern group data after markdown parsing for ${path.join(
patternlab.config.paths.source.patterns,
groupRelPath[0] || pattern.subdir,
GROUP_DOC_PREFIX + pattern.patternGroup + FILE_EXTENSION
)}`
);
logger.warning(err);
}
}
}

// Read Documentation for Pattern-Subgroup
try {
if (pattern.patternSubgroup) {
const subgroupRelPath = pattern.relPath.split(path.sep);
const markdownFileNameSubgroup = path.resolve(
patternlab.config.paths.source.patterns,
subgroupRelPath[0],
subgroupRelPath[1],
GROUP_DOC_PREFIX + pattern.patternSubgroup + FILE_EXTENSION
);
const markdownFileContentsSubgroup = fs.readFileSync(
markdownFileNameSubgroup,
'utf8'
);
const markdownObjectSubgroup = markdown_parser.parse(
markdownFileContentsSubgroup
);

if (!_.isEmpty(markdownObjectSubgroup)) {
pattern.patternSubgroupData = markdownObjectSubgroup;
}
} catch (err) {
// do nothing when file not found
if (err.code !== 'ENOENT') {
logger.warning(
`There was an error setting pattern subgroup data after markdown parsing for ${path.join(
patternlab.config.paths.source.patterns,
path.parse(pattern.subdir).dir,
path.parse(pattern.subdir).base,
GROUP_DOC_PREFIX + pattern.patternSubgroup + FILE_EXTENSION
)}`
try {
const markdownFileNameSubgroup = path.resolve(
patternlab.config.paths.source.patterns,
subgroupRelPath[0],
subgroupRelPath[1],
GROUP_DOC_PREFIX + pattern.patternSubgroup + FILE_EXTENSION
);
logger.warning(err);
const markdownFileContentsSubgroup = fs.readFileSync(
markdownFileNameSubgroup,
'utf8'
);
const markdownObjectSubgroup = markdown_parser.parse(
markdownFileContentsSubgroup
);

if (!_.isEmpty(markdownObjectSubgroup)) {
pattern.patternSubgroupData = markdownObjectSubgroup;
}
} catch (err) {
// do nothing when file not found
if (err.code !== 'ENOENT' && err.code !== 'ENOTDIR') {
logger.warning(
`There was an error setting pattern subgroup data after markdown parsing for ${path.join(
patternlab.config.paths.source.patterns,
subgroupRelPath[0],
subgroupRelPath[1],
GROUP_DOC_PREFIX + pattern.patternSubgroup + FILE_EXTENSION
)}`
);
logger.warning(err);
}
}
}
};