fix path gets not resolved in pl create script #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ringods @sghoweri I did a full debug of the npx create-pattern-lab script and found out that resolve.cache has still the %USER_HOME%/appdata... paths in it. The documentation gives a hint that you can define your own lookup paths and that's what I did when we set our process variable while the init script is running. |
Contributor
Author
|
I merged this now since it was a critical topic. It seems to work as expected. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While changes were made to the package resolving, some errors appeared. This should fix these errors.
Closes #1157
Closes #1247
Closes #1257
Summary of changes:
Added CWD to the installation of packages
Added an approach where packages are relative to their base like the default of require.resolve does.