fix(1049): Treat folders like patterns only if they're subfolders of …

[kmonahan]

…pattern groupings

Closes #1049

Summary of changes:
Limits the separated pattern-folder support to patterns that are nested at least two levels deep. This seems to be how the PHP version works and supports both of the following use cases:
[patternType]/[patternSubType]/[pattern]/[pattern].hbs (which appears to be the original intent of #992 and [patternType]/[patternSubType]/[pattern].hbs, where the pattern and patternSubType are the same (as in the use case in #1049, where the patternSubType button might contain button.hbs and button--variant.hbs.

[kryp71c]

It seems the pattern states are missing from the nav with this change.

[kmonahan]

Hey @kryp71c,
I'm not quite sure what you mean. Can you give an example of a pattern that's missing? I can then take a look.

[coreylafferty]

@kmonahan I think they mean the state is missing. For example, if you create a file named dog.md next to your dog.mustache or dog.twig file, and add the following contents:

---
el: .dog
title: Dog
state: inreview
---

the 'inreview' yellow dot doesn't show next to the item in the menu. I suspect that's due to the removal of the 'info' variable being passed in.

[kmonahan]

Ah, got it. Thanks! WIll investigate and update my branch.

[kmonahan]

Dug into this one and I think what actually needs to be fixed here is what's being done in PR #1058 .

I tested locally with a pattern called Dog with a state of 'inreview' and a pattern called Dog Special with a state of 'inprogress'. When I organized the patterns in the patternType/patternSubtype structure (so my templates and markdown files were in 00-animals/dog/), I see the state indicators in the nav:

Likewise, when I organized the patterns in the patternType/patternSubtype/pattern structure (so the dog template and markdown files were in 00-animals/dogs/dog/), I also see the state indicators in the nav:

Where I don't see the indicators is when I use the patternType/patternSubtype structure with only one pattern in it: 00-animals/dog/ without the Dog Special pattern. Previously, this worked if the directory had the same name as the pattern but did not work if the names were different. When I rename my folder to "doggie", it's clearer that what's showing up in the nav is just the directory with no subnav listing the patterns underneath it, and hence no status indicator:

Rather than have the status indicator appear in the nav next to the pattern subtype name if it matches the pattern, my desired behavior here would be for the pattern subtype to have a submenu listing the pattern(s) and their status indicators. When I merged #1058 in locally, that's exactly what I get:

So rather than make further changes here, I think it makes more sense to leave this PR as-is and handle the directory flattening issue in 1058, unless there are other state display issues beyond that one.

[coreylafferty]

@sghoweri @bmuenzenmeyer now that #1058 is accepted, I believe this PR should be good to go.

[bmuenzenmeyer]

i'll need some time to re-read through this

[sghoweri]

Hey thanks so much for this @kmonahan!

I've tested this out locally with a few different combos of nested folders / patterns (including adding State to a few of them to double-check that 😉) and can verify that this all seems to be working as expected (and as an added bonus, now seems to match the overall expected behavior of Pattern Lab PHP as well). 🎉

Nice work!