Skip to content

fix(engine_twig_php): Pseudo patterns Twig PHP #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2019
Merged

fix(engine_twig_php): Pseudo patterns Twig PHP #1046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
226aa8b
fix(engine_twig_php): Pseudo patterns Twig PHP
Aug 26, 2019
257019a
Merge branch 'dev' into feature/1045--pseudo-twigphp
sghoweri Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/engine-twig-php/lib/engine_twig_php.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,17 @@ const engine_twig_php = {

renderPattern(pattern, data) {
return new Promise((resolve, reject) => {
const patternPath = path.isAbsolute(pattern.relPath)
? path.relative(patternLabConfig.paths.source.root, pattern.relPath)
// If this is a pseudo pattern the relPath will be incorrect.
// i.e. /path/to/pattern.json
// Twig can't render that file so we need to use the base patterns
// relPath instead.
const relPath = pattern.isPseudoPattern
? pattern.basePattern.relPath
: pattern.relPath;

const patternPath = path.isAbsolute(relPath)
? path.relative(patternLabConfig.paths.source.root, relPath)
: relPath;
// console.log(patternPath);

let details = '';
Expand Down