Fix parsing of multiple consecutive path wildcard, unpivot, path expressions #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am357
approved these changes
Jul 6, 2023
Contributor
am357
left a comment
am357
left a comment
There was a problem hiding this comment.
Nice fix and nice simplification as well! Thank you!
Co-authored-by: Arash Maymandi <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 56 56
Lines 14737 14737
Branches 14737 14737
=======================================
Hits 11960 11960
Misses 2260 2260
Partials 517 517 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5240 Number failing in both: 1044 Number passing in Base (5629e88) but now fail: 0 Number failing in Base (5629e88) but now pass: 0 |
jpschorr
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403.
Fixes #404.
Fix the parsing of multiple, consecutive path wildcard (e.g.
a[*][*][*]), unpivot (e.g.a.*.*.*), and path expressions (e.g.a[1 + 2][3 + 4][5 + 6]). Previously these would not parse correctly.Points the
partiql-testsgit submodule to partiql/partiql-tests#100 branch. Once that's merged, will rebase this PR to point topartiql-testsmain.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.