Skip to content

Conversation

@Koustavd18
Copy link
Contributor

update: On delete a saved filter user have to confirm their action

@Koustavd18 Koustavd18 requested a review from nitisht August 13, 2024 08:35
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When selecting y on confirmation page, the query still doesn't get deleted

@Koustavd18 Koustavd18 requested a review from nitisht August 13, 2024 10:26
@Koustavd18
Copy link
Contributor Author

@nitisht Issue resolved

@nitisht
Copy link
Member

nitisht commented Aug 13, 2024

Let's fix the linting then we can merge

@nitisht nitisht merged commit e7eca08 into parseablehq:main Aug 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@Koustavd18 Koustavd18 deleted the confirm/delete branch August 23, 2024 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants