Skip to content

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Sep 7, 2022

Description

Replace custom schema type with arrow schema wrapped in Option. If metadata was able to load a schema then it will be of Some variant, in case there is no schema ( new stream ) then the None variant will be used. This reduced number of times serialization to schema happens and this schema will be directly passed on to future event processing and queries.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Replace custom schema type with arrow schema wrapped in Option. If metadata was able to load a schema then it will be of Some variant, in case there is no schema ( new stream ) then the None variant will be used. This reduced number of times serialization to schema happens and this schema will be directly passed on to future event processing and queries.
@nitisht nitisht merged commit a44b530 into parseablehq:main Sep 7, 2022
@trueleo trueleo deleted the type_schema branch September 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants