Skip to content

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Sep 5, 2022

Description

Datafusion re exports arrow and parquet. Use these for version compatiblity with datafusion.

Changes

  • Remove direct dependency on arrow and parquet, use datafusion::arrow and datafusion::parquet.
  • Remove other unused dependencies.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

datafusion re exports arrow and parquet. Use these for version compatiblity with datafusion.
@nitisht nitisht merged commit d83f099 into parseablehq:main Sep 5, 2022
@trueleo trueleo deleted the datafusion_types branch September 5, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants