Enhance: Improve query performance by splitting time filters #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsinhaparseable
approved these changes
Aug 29, 2024
| let (listing_time_fiters, new_time_filters) = | ||
| return_listing_time_filters(&merged_snapshot.manifest_list, time_filters); | ||
|
|
||
| let listing_tables = if let Some(listing_time_filter) = listing_time_fiters { |
There was a problem hiding this comment.
@parmesant lets rename the remote_table to listing_exec
also, can we optimise this part of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves query performance by splitting time filters for older data requiring
listing tableand newer data usingmanifestfiles and creating two separate execution plans for both.Tests show considerable improvement in querying time (no standardized test available)
Description
This PR has: