Skip to content

Conversation

@nikhilsinhaparseable
Copy link
Contributor

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht
Copy link
Member

nitisht commented Apr 11, 2024

cc @Eshanatnight did we change the path on purpose earlier?

@Eshanatnight
Copy link
Contributor

No the path was never under api/v1 it was just address/readiness and address/liveness

@nitisht
Copy link
Member

nitisht commented Apr 11, 2024

No the path was never under api/v1 it was just address/readiness and address/liveness

It was under api/v1/liveness earlier:

// GET "/liveness" ==> Liveness check as per https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-command

@Eshanatnight
Copy link
Contributor

Yes I see that, I was a mistake on my end. I apologise

@nitisht nitisht merged commit c1c0861 into parseablehq:main Apr 12, 2024
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants