rename P_NODE_URL to P_INGESTOR_URL #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
changes required in Apart from that LGTM |
nikhilsinhaparseable
approved these changes
Apr 8, 2024
Contributor
nikhilsinhaparseable
left a comment
nikhilsinhaparseable
left a comment
There was a problem hiding this comment.
i have fixed the code where it was still looking for node_url, good to merge now
nikhilsinhaparseable
added a commit
to nikhilsinhaparseable/parseable
that referenced
this pull request
Apr 20, 2024
Co-authored-by: Nikhil Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P_INGESTOR_URLis a better name for this env variable.