Skip to content

removing check of ingesters' liveness at query server start #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

removing check of ingesters' liveness at query server start #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions server/src/handlers/http/modal/query_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
*
*/

use crate::handlers::http::cluster::utils::check_liveness;
use crate::handlers::http::cluster::{self, get_ingester_info};
use crate::handlers::http::cluster;
use crate::handlers::http::middleware::RouteExt;
use crate::handlers::http::{base_path, cross_origin_config, API_BASE_PATH, API_VERSION};

Expand Down Expand Up @@ -45,17 +44,6 @@ impl ParseableServer for QueryServer {
prometheus: actix_web_prometheus::PrometheusMetrics,
oidc_client: Option<crate::oidc::OpenidConfig>,
) -> anyhow::Result<()> {
let data = get_ingester_info().await?;

// on subsequent runs, the qurier should check if the ingester is up and running or not
for ingester in data.iter() {
if !check_liveness(&ingester.domain_name).await {
eprintln!("Ingester at {} is not reachable", &ingester.domain_name);
} else {
println!("Ingester at {} is up and running", &ingester.domain_name);
}
}

let oidc_client = match oidc_client {
Some(config) => {
let client = config
Expand Down