Skip to content

feat: Impl Query Server Changes #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2024
Merged

feat: Impl Query Server Changes #701

merged 4 commits into from
Mar 18, 2024

Conversation

@Eshanatnight
Copy link
Contributor

@Eshanatnight Eshanatnight commented Mar 14, 2024 •
edited
Loading

Description

  1. Add: Schema API for Ingestion Server
  2. RM: Redundant API Endpoints
  3. feat: Last min data is Queryable
  4. Add: Unit Tests
  5. If the Query returns empty results, an empty vector will be returned rather than an error

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@Eshanatnight
Copy link
Contributor Author

Eshanatnight commented Mar 15, 2024 •
edited
Loading

Issues

No. Description Pointers Priority Status
1. Staging Query Not working xxxxxxxxx done 👌
2. Stream Sync on new Start Stream Sync on startup 2 👨‍🏭
3. if 2 Ingest Server are started, one is able to ingest, other is not. Erroring with error - You don't have permission to access this resource. Please contact your administrator for assistance.
4. Query is being send to ingest servers always 1 👨‍🏭

@Eshanatnight
feat: Impl Query Server
c01fafb 
Add: Schema API for Ingestion Server
RM: Redundant API Endpoints
feat: Last min data is Queryable
Add: Unit Tests
@Eshanatnight
fix: func flatten_objects_for_count
a2d3cd4 
Fix function flatten_objects_for_count
Update Tests
@Eshanatnight
fix: base_path_without_preciding_slah function
f6f76cf
@Eshanatnight
Copy link
Contributor Author

Eshanatnight commented Mar 17, 2024

Changes

  1. If the Query returns empty results, an empty vector will be returned rather than an error

@Eshanatnight
fix: Session Context not in sync
9e1ec9c 
1. Session Context was not being synced at the time of schema update
2. Make struct TableScanVisitor pub at crate level
@nikhilsinhaparseable nikhilsinhaparseable merged commit 8717a26 into parseablehq:distributed Mar 18, 2024
@Eshanatnight Eshanatnight deleted the impl-query-server branch March 19, 2024 08:18
Eshanatnight added a commit to Eshanatnight/parseable that referenced this pull request Apr 1, 2024
@Eshanatnight
feat: Impl Query Server Changes (parseablehq#701)
2b65ecd 
* feat: Impl Query Server

Add: Schema API for Ingestion Server
RM: Redundant API Endpoints
feat: Last min data is Queryable
Add: Unit Tests

* fix: func flatten_objects_for_count

Fix function flatten_objects_for_count
Update Tests

* fix: base_path_without_preciding_slah function

* fix: Session Context not in sync

1. Session Context was not being synced at the time of schema update
2. Make struct TableScanVisitor pub at crate level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eshanatnight @nikhilsinhaparseable