remove first-event-at from stream.json but keep it in stats api #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
reviewed
Feb 26, 2024
| pub created_at: String, | ||
| #[serde(rename = "first-event-at")] | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub first_event_at: Option<String>, |
Member
There was a problem hiding this comment.
even the first_event_at is not needed right?
nikhilsinhaparseable
added a commit
that referenced
this pull request
Mar 4, 2024
* create first-created-at on the fly for stats api (#675) * prepare for release v0.9 (#678) * fix: Invalid Cargo.toml (#680) * feat: distributed Implementation of the Parseable Server (#656) This PR contains the ingester side changes --------- Co-authored-by: Nikhil Sinha <[email protected]> Co-authored-by: Nitish Tiwari <[email protected]>
nikhilsinhaparseable
added a commit
to nikhilsinhaparseable/parseable
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove first-event-at from stream.json but keep it in stats api