fix: avoid removal of retention configuration while updating snapshot #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsinhaparseable
approved these changes
Feb 26, 2024
nikhilsinhaparseable
pushed a commit
to nikhilsinhaparseable/parseable
that referenced
this pull request
Apr 20, 2024
…parseablehq#673) current: when server restarts, the retention config gets deleted from stream.json change: retention config does not get deleted on server restart Fixes: parseablehq#654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654
Description
Added
retentioninObjectStoreFormatstruct so that update_snapshot gets the complete stream metadata information and don't override the retention configuration.