Fixes #616 feature: allow configurable duration for data push to S3 #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create parquet file by grouping all arrow files (in staging) for the duration provided in env variable P_STORAGE_UPLOAD_INTERVAL also check if arrow files vector is not empty, then sort the arrow files and create key for parquet file from last file from sorted arrow files vector
nikhilsinhaparseable
changed the title
sinhaashish
reviewed
Jan 24, 2024
| .or_default() | ||
| .push(arrow_file_path); | ||
|
|
||
| //check if arrow files is not empty, fetch the parquet file path from last file from sorted arrow file list |
There was a problem hiding this comment.
Try this out
Don't use unwrap(). It panics.
if !arrow_files.is_empty() {
arrow_files.sort();
let key = Self::arrow_path_to_parquet(arrow_files.last().unwrap_or_default());
let entry = grouped_arrow_file.entry(key.clone()).or_default();
entry.extend(arrow_files);
}
nitisht
approved these changes
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616
create parquet file by grouping all arrow files (in staging) for the duration provided in env variable P_STORAGE_UPLOAD_INTERVAL also check if arrow files vector is not empty,
then sort the arrow files and create key for parquet file from last file from sorted arrow files vector