Skip to content

Ignore empty alerts #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

Ignore empty alerts #59

merged 1 commit into from
Aug 24, 2022

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 24, 2022

Description

Ignore unset alerts on stream when loading from s3. This PR fixes this by using unwrap_or_default on result instead of early return

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@trueleo trueleo requested a review from nitisht August 24, 2022 16:04
@nitisht nitisht merged commit 28e8884 into parseablehq:main Aug 24, 2022
@trueleo trueleo deleted the ignore_empty_alerts branch August 24, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitisht nitisht nitisht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht