Skip to content

Keep openid user information in metadata #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2023
Merged

Keep openid user information in metadata #559

merged 7 commits into from
Nov 23, 2023

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Nov 22, 2023 •
edited
Loading

Fixes #540.

Description

This PR attaches a UserInfo struct in user config. This is updated upon user login if any changes to user profile is made.

Alternatives

  • Parseable can provide user info upon login by caching the user info returned from openid service. This will limit it to just oidc users and would not change metadata.
  • Parseable can immediately attach user info as cookie upon login.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@trueleo trueleo marked this pull request as draft November 22, 2023 14:02
@trueleo trueleo marked this pull request as ready for review November 22, 2023 16:26
@trueleo trueleo changed the title Keep user information in metadata and provide API for it. Keep user information in metadata. Nov 22, 2023
@trueleo trueleo changed the title Keep user information in metadata. Keep openid user information in metadata Nov 22, 2023
nitisht
nitisht approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 3aefb9b into parseablehq:main Nov 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
@trueleo trueleo deleted the userinfo branch December 14, 2023 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nitisht nitisht nitisht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Authenticated user details in .parseable.json for OIDC users

2 participants

@trueleo @nitisht