Skip to content

Fix warnings #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix warnings #557

merged 1 commit into from
Nov 18, 2023

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Nov 18, 2023

Fixes #XXXX.

Description

Removes warning on static lifetimes by marking them 'static explicitly. Required by rust 1.75.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit ac98b5d into parseablehq:main Nov 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
@trueleo trueleo deleted the 174fix branch November 22, 2023 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht