Skip to content

Fix prefix ordering #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix prefix ordering #549

merged 1 commit into from
Nov 2, 2023

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Nov 2, 2023 •
edited
Loading

Description

Set prefix ordering to latest to oldest for better query results in general usecases. Target partition is set to 1 because Datafusion enforce ordering optimization will intelligently create more partitions when needed.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 5cdd56b into parseablehq:main Nov 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@trueleo trueleo deleted the prefix-ordering branch November 22, 2023 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht