Skip to content

Make tag in reader role optional #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2023
Merged

Make tag in reader role optional #463

merged 2 commits into from
Aug 3, 2023

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 3, 2023

Description

Fixes reader role in RBAC.

  • Make Tags optional
  • Fix authentication for permission with "*" wildcard stream

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit e2032ab into parseablehq:main Aug 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
@trueleo trueleo deleted the fix_rbac branch August 7, 2023 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht