Skip to content

Fix get retention api #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix get retention api #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/src/handlers/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@ pub fn configure_routes(cfg: &mut web::ServiceConfig) {
web::resource("/stats").route(web::get().to(logstream::get_stats)),
)
.service(
// GET "/logstream/{logstream}/retention" ==> Set retention for given logstream
web::resource("/retention").route(web::put().to(logstream::put_retention)),
web::resource("/retention")
// PUT "/logstream/{logstream}/retention" ==> Set retention for given logstream
.route(web::put().to(logstream::put_retention))
// GET "/logstream/{logstream}/retention" ==> Get retention for given logstream
.route(web::get().to(logstream::get_retention)),
);

cfg.service(
Expand Down
17 changes: 17 additions & 0 deletions server/src/handlers/http/logstream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,23 @@ pub async fn put_alert(
))
}

pub async fn get_retention(req: HttpRequest) -> Result<impl Responder, StreamError> {
let stream_name: String = req.match_info().get("logstream").unwrap().parse().unwrap();
let objectstore = CONFIG.storage().get_object_store();

if !objectstore.stream_exists(&stream_name).await? {
return Err(StreamError::StreamNotFound(stream_name.to_string()));
}

let retention = CONFIG
.storage()
.get_object_store()
.get_retention(&stream_name)
.await?;

Ok((web::Json(retention), StatusCode::OK))
}

pub async fn put_retention(
req: HttpRequest,
body: web::Json<serde_json::Value>,
Expand Down