Skip to content

Add staging file size #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add staging file size #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ lazy_static! {
.expect("metric can be created");
pub static ref STORAGE_SIZE: IntGaugeVec = IntGaugeVec::new(
Opts::new("storage_size", "Storage size bytes").namespace(METRICS_NAMESPACE),
&["stream", "format"]
&["type", "stream", "format"]
)
.expect("metric can be created");
pub static ref STAGING_FILES: IntGaugeVec = IntGaugeVec::new(
Expand Down Expand Up @@ -117,7 +117,7 @@ pub fn load_from_global_stats() {
.with_label_values(&[&stream_name, "json"])
.set(stats.ingestion as i64);
STORAGE_SIZE
.with_label_values(&[&stream_name, "parquet"])
.with_label_values(&["data", &stream_name, "parquet"])
.set(stats.storage as i64)
}
}
11 changes: 10 additions & 1 deletion server/src/storage/object_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,15 @@ pub trait ObjectStorage: Sync + 'static {
.with_label_values(&[stream])
.set(files.len() as i64);

for file in &files {
let file_size = file.metadata().unwrap().len();
let file_type = file.extension().unwrap().to_str().unwrap();

STORAGE_SIZE
.with_label_values(&["staging", stream, file_type])
.add(file_size as i64);
}

let record_reader = MergedRecordReader::try_new(&files).unwrap();

let mut parquet_table = CACHED_FILES.lock().unwrap();
Expand Down Expand Up @@ -355,7 +364,7 @@ pub trait ObjectStorage: Sync + 'static {
let stats = STREAM_INFO.read().unwrap().get(stream).map(|metadata| {
metadata.stats.add_storage_size(compressed_size);
STORAGE_SIZE
.with_label_values(&[stream, "parquet"])
.with_label_values(&["data", stream, "parquet"])
.add(compressed_size as i64);
Stats::from(&metadata.stats)
});
Expand Down