Skip to content

Remove merge #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove merge #325

wants to merge 2 commits into from

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Mar 2, 2023

Fixes #XXXX.

Description

Remove kmerge by writing to one file at a time and switching to different one if schema changes.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht marked this pull request as ready for review March 3, 2023 09:39
@nitisht
Copy link
Member

nitisht commented Mar 4, 2023

Closing in favour of #326

@nitisht nitisht closed this Mar 4, 2023
@trueleo trueleo deleted the remove_merge branch March 6, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht