Add version to alerts #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syepes
reviewed
Feb 27, 2023
|
|
||
| let alert = &mut alerts[0]; | ||
|
|
||
| alert["labels"].as_object_mut().expect("is object").extend( |
Contributor
There was a problem hiding this comment.
Small suggestion, we should not have all the rules details as the standard labels (additional_labels) as they will be visible and if just one changes it create a new alert.
We could have the more internal (metadata) labels (__meta_xx), for these kind of rule details
Member
There was a problem hiding this comment.
Thanks @syepes . It is not clear from the docs, but are the Prometheus relabeling rules applicable for alertmanager as well?
Contributor
There was a problem hiding this comment.
Thanks @syepes . It is not clear from the docs, but are the Prometheus relabeling rules applicable for alertmanager as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
=%and!%for contains and not contain variant of string rule.