Skip to content

Move Prometheus metrics endpoint to /api/v1/metrics #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Move Prometheus metrics endpoint to /api/v1/metrics #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cd32f3
Move Prometheus path to `/api/v1/metrics`
nitisht Feb 15, 2023
955e988
fmt fix
nitisht Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,10 @@ fn ingest_path() -> String {
"/ingest".to_string()
}

pub fn metrics_path() -> String {
format!("{}/metrics", base_path())
}

fn alert_path(stream_name: &str) -> String {
format!("{}/alert", logstream_path(stream_name))
}
Expand Down
4 changes: 2 additions & 2 deletions server/src/metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use actix_web_prometheus::{PrometheusMetrics, PrometheusMetricsBuilder};
use lazy_static::lazy_static;
use prometheus::{HistogramOpts, HistogramVec, IntCounterVec, IntGaugeVec, Opts, Registry};

use crate::metadata::STREAM_INFO;
use crate::{metadata::STREAM_INFO, metrics_path};

pub const METRICS_NAMESPACE: &str = env!("CARGO_PKG_NAME");

Expand Down Expand Up @@ -87,7 +87,7 @@ pub fn build_metrics_handler() -> PrometheusMetrics {

let prometheus = PrometheusMetricsBuilder::new(METRICS_NAMESPACE)
.registry(registry)
.endpoint("/metrics")
.endpoint(metrics_path().as_str())
.build()
.expect("Prometheus initialization");

Expand Down