Skip to content

Apply clippy suggestions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Apply clippy suggestions #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74c5ea4
Derive Eq beside PartialEq
trueleo Aug 12, 2022
7f1c3b5
Remove unneeded return keyword
trueleo Aug 12, 2022
bc6ecc2
Fix formatting
trueleo Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions server/src/handlers/logstream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,15 +244,13 @@ pub async fn put_alert(req: HttpRequest, body: web::Json<serde_json::Value>) ->
}
.to_http(),
},
Err(e) => {
return response::ServerResponse {
msg: format!(
"failed to set alert configuration for log stream {} due to err: {}",
stream_name, e
),
code: StatusCode::BAD_REQUEST,
}
.to_http();
Err(e) => response::ServerResponse {
msg: format!(
"failed to set alert configuration for log stream {} due to err: {}",
stream_name, e
),
code: StatusCode::BAD_REQUEST,
}
.to_http(),
}
}
8 changes: 4 additions & 4 deletions server/src/validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ const DENIED_NAMES: &[&str] = &[
"select", "from", "where", "group", "by", "order", "limit", "offset", "join", "and",
];

#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
#[derive(Default, Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Alerts {
pub alerts: Vec<Alert>,
}

#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
#[derive(Default, Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Alert {
pub name: String,
Expand All @@ -43,7 +43,7 @@ pub struct Alert {
pub target: Vec<Target>,
}

#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
#[derive(Default, Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Rule {
pub field: String,
Expand All @@ -52,7 +52,7 @@ pub struct Rule {
pub within: String,
}

#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
#[derive(Default, Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Target {
pub name: String,
Expand Down