Skip to content

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Jan 13, 2023

Fixes #258

Description

  • Move remove link procedure to Drop impl for table provider because it always has to run on exit.
  • If any parquet file path is not in File table during lookup then we treat it as if it is already uploaded and skip past it
  • Fixed possibility of double upsert when generating possible parquet paths for query.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

* Move remove link procedure to Drop impl for table provider because it always
has to run on exit.
* If any parquet file path is not in File table during lookup then we treat it
as if it is already uploaded and skip past it
* Fixed possibility of double upsert when generating possible parquet paths
for query.
@nitisht nitisht merged commit 63ed836 into parseablehq:main Jan 14, 2023
@trueleo trueleo deleted the file_link branch January 14, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parseable Service goes into panic randomly

2 participants