Skip to content

Fix banner if fetching latest release fails #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix banner if fetching latest release fails #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions server/src/banner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,24 +101,10 @@ pub mod about {
current_version,
);

// check for latest release, if it cannot be fetched then print error as warn and return
let latest_release = match update::get_latest() {
Ok(latest_release) => latest_release,
Err(_) => {
return;
if let Ok(latest_release) = update::get_latest() {
if latest_release.version > current_version {
print_latest_release(latest_release);
}
};

if latest_release.version > current_version {
let time_since_latest_release = chrono::Utc::now() - latest_release.date;
let time_since_latest_release = humanize_time(time_since_latest_release);

let fmt_latest_version = format!(
" ( v{} released {} ago. Download new release from https://github.com/parseablehq/parseable/releases/latest )",
latest_release.version, time_since_latest_release
);

eprint!("{}", fmt_latest_version.red());
}

eprintln!(
Expand All @@ -129,6 +115,16 @@ pub mod about {
);
}

fn print_latest_release(latest_release: update::LatestRelease) {
let time_since_latest_release = chrono::Utc::now() - latest_release.date;
let time_since_latest_release = humanize_time(time_since_latest_release);
let fmt_latest_version = format!(
" ( v{} released {} ago. Download new release from https://github.com/parseablehq/parseable/releases/latest )",
latest_release.version, time_since_latest_release
);
eprint!("{}", fmt_latest_version.red());
}

pub fn print() {
// print current version
let current = current();
Expand Down