Skip to content

Refactor handlers #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

Refactor handlers #243

merged 2 commits into from
Jan 4, 2023

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Jan 4, 2023

Description

  • Use StreamError type for error propogation
  • Handlers should now return json with appropriate content-type

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

trueleo added 2 commits January 4, 2023 12:27
@trueleo
Refactor handlers
1f76e8b 
* Use StreamError type for error propogation
* Handlers should now return json with appropriate content-type
@trueleo
Fix
263f36f
@nitisht nitisht merged commit 100b848 into parseablehq:main Jan 4, 2023
@trueleo trueleo deleted the response branch January 4, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trueleo @nitisht