Automatically add p_datetime if there are no suitable time columns #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds ability for a stream to define altered schema with a dedicated timestamp column if there is none provided in the first request. This column is called `p_datetime`
nitisht
reviewed
Dec 27, 2022
server/src/event.rs
Outdated
| type LocalWriterGuard<'a> = MutexGuard<'a, Option<StreamWriter<std::fs::File>>>; | ||
|
|
||
| const DEFAULT_TIMESTAMP_KEY: &str = "p_timestamp"; | ||
| const TIME_KEYS: &[&str] = &["time", "datetime", "timestamp"]; |
Member
There was a problem hiding this comment.
const TIME_KEYS: &[&str] = &["time", "datetime", "timestamp", “date”];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ability for a stream to define altered schema with a dedicated timestamp column if there is none provided in the first request. This column is called
p_datetimeThis PR has: