Add option to use local filesystem for storage #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables Parseable server to accept additional arguments ( drive or s3) to switch between storage. Local filesystem behaves like an object storage through implementation of ObjectStorage trait. All methods of LocalFS are implemented using tokio::fs Configuration provided on runtime is used to select a storage provider. The storage object is handled as trait objects hence the requirement of ?Sized on some methods. Calls to S3 are replaced with appropriate methods.
trueleo
changed the title
nitisht
approved these changes
Dec 17, 2022
Member
nitisht
left a comment
nitisht
left a comment
There was a problem hiding this comment.
LGTM, there are several improvements required, we can do those incrementally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Parseable server to accept additional arguments ( drive or s3) to switch between storage option.
Local filesystem behaves as an storage provider through implementation of ObjectStorage trait. All
methods of LocalFS are implemented using tokio::fs
Configuration provided on runtime is used to select a storage provider. The storage object is handled as
trait objects hence the requirement of ?Sized on some methods. Calls to S3 are replaced with appropriate methods.
This PR has: