Skip to content

Conversation

@nitisht
Copy link
Member

@nitisht nitisht commented Dec 12, 2022

In case the user specifies x-p-stream in the header and the stream doesn't exist, server failed with stream doesn't exist error.

But in highly automated environments like kubernetes, it is important to dynamically create the stream so that Parseable is able to ingest the log data quickly without too much user involvement.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviours.

In case the user specifies x-p-stream in the header and the stream
doesn't exist, server failed with stream doesn't exist error.

But in highly automated environments like kubernetes, it is
important to dynamically create the stream so that Parseable
is able to ingest the log data quickly without too much user
involvement.
@nitisht nitisht requested a review from trueleo December 12, 2022 07:08
@AdheipSingh
Copy link
Contributor

@nitisht does this require change in collector ?

@nitisht
Copy link
Member Author

nitisht commented Dec 12, 2022

old api will still work, but with this, collector code can be simplified

@nitisht nitisht merged commit 33009bf into parseablehq:main Dec 12, 2022
@nitisht nitisht deleted the header branch December 12, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants