Skip to content

Conversation

@123vivekr
Copy link
Contributor

Description

This API will push logs to stream based on header.

Separated out pushing log logic into push_logs() - avoid code redundancy

Expose /ingest API which push logs to a stream name based on header.
The header key is X-P-STREAM-NAME


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

This API will push logs to stream based on header.
@nitisht
Copy link
Member

nitisht commented Dec 11, 2022

Thanks for the PR @123vivekr we'll take a look

Copy link
Contributor

@trueleo trueleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

@nitisht nitisht merged commit 9c1c13d into parseablehq:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants