Skip to content

Rust fixes as per vscode #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2022
Merged

Rust fixes as per vscode #199

merged 4 commits into from
Nov 24, 2022

Conversation

@AdheipSingh
Copy link
Contributor

@AdheipSingh AdheipSingh commented Nov 24, 2022

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@AdheipSingh AdheipSingh requested review from nitisht and trueleo and removed request for trueleo November 24, 2022 12:41
@nitisht nitisht merged commit 4d703ae into parseablehq:main Nov 24, 2022
@AdheipSingh AdheipSingh deleted the rust-fixes branch November 24, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitisht nitisht Awaiting requested review from nitisht

@trueleo trueleo Awaiting requested review from trueleo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdheipSingh @nitisht