Skip to content

Conversation

@123vivekr
Copy link
Contributor

Closes #146

Description

Show git semver in banner


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht
Copy link
Member

nitisht commented Nov 22, 2022

Thanks for the PR @123vivekr . @trueleo can you take a look

@trueleo
Copy link
Contributor

trueleo commented Nov 22, 2022

@nitisht Looking

@123vivekr 123vivekr force-pushed the semver branch 2 times, most recently from 6ba9887 to ad7b6f1 Compare November 22, 2022 11:09
@trueleo
Copy link
Contributor

trueleo commented Nov 22, 2022

@nitisht Just a note, git version is the same as build version until you add a tag like 0.0.6-*** .. So BUILD_SEMVER is the last release semver and GIT_SEMVER uses last tag ( like 0.0.6-aplha )

@nitisht nitisht merged commit 79519b9 into parseablehq:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Document] How to send logs to Parseable from a Rust application

3 participants