Skip to content

Create a Dockerfile that outputs a static binary during build #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Create a Dockerfile that outputs a static binary during build #190

merged 1 commit into from
Oct 30, 2022

Conversation

@Mayon-Francis
Copy link
Contributor

@Mayon-Francis Mayon-Francis commented Oct 30, 2022

Description

Can be built using:

docker build -f Dockerfile.static -o static-build .

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

nitisht
nitisht approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@nitisht nitisht merged commit 66ffbb3 into parseablehq:main Oct 30, 2022
@Mayon-Francis
Copy link
Contributor Author

Mayon-Francis commented Oct 30, 2022

@nitisht Should there be a .dockerignore to avoid copying the "target" folder when building?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitisht nitisht nitisht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mayon-Francis @nitisht