Skip to content

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 15, 2022

Description

This PR bumps few crate version to possible latest while also fixing few error generated from the change.

Arrow Schema now derives serde and removes explicit to_json method. This broke code at few places which are fixed by directly depending on arrow_schema crate with serde feature enabled, calls to_json is replaced by to_string method from serde_json according to usage.

actix_web_httpauth crate requires a different function signature for validator which is fixed as well.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Arrow Schema now derives serde and removes explicit to_json method.
This broke api at few places which are fixed by directly depending on
arrow_schema crate with serde feature enabled, calls to_json is replaced by
to_string method from serde_json according to usage.

actix_web_httpauth crate requires a different funtion signature for validator
which is fixed as well.
@nitisht nitisht self-requested a review October 15, 2022 11:18
@nitisht nitisht merged commit 8e74213 into parseablehq:main Oct 15, 2022
@trueleo trueleo deleted the bump_verison branch October 15, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants