Skip to content

refactor: improve dockerfile using latest binary #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2022
Merged

refactor: improve dockerfile using latest binary #157

merged 1 commit into from
Oct 8, 2022

Conversation

@adripo
Copy link
Contributor

@adripo adripo commented Oct 7, 2022

Fixes #156

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht self-requested a review October 8, 2022 02:32
@nitisht
Copy link
Member

nitisht commented Oct 8, 2022

Thank you for the PR @adripo looks great!

@nitisht nitisht merged commit cf60622 into parseablehq:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitisht nitisht nitisht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve dockerfile to use a release binary instead of building the rust binary

2 participants

@adripo @nitisht