Lock metadata on first event. #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple requests reaches event processing too quickly then many threads race to register first event. This is problematic as it means server may drop many request after erroring/panicking on local writer. This PR fixes this issue by locking metadata with write lock beforehand in case of first event. This prevents other thread from reading metadata and thus blocks other requests until first event has processed. Todo: This can be seperate issue but as metadata expects that all it's method are panic free there should not be any panic inside s3 client when processing for first event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple requests reaches event processing too quickly then many threads race to register first event. This is problematic as it means server may drop many request after panicking on local writer.
This PR fixes this issue by locking metadata with write lock beforehand in case of first event. This prevents other thread from reading metadata and thus blocks other requests until first event has processed.
Todo
This PR has: