Skip to content

Bump aws_sdk_s3 version and provide sleep and retry impl for S3 client #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Bump aws_sdk_s3 version and provide sleep and retry impl for S3 client #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c9a1b
Bump aws_sdk_s3 version and provide sleep and retry impl for S3 client
trueleo Oct 2, 2022
272ebe2
Set max retry attemps to 5
trueleo Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ actix-cors = "0.6"
actix-files = "0.6.1"
anyhow = { version = "1.0.43", features = ["backtrace"] }
async-trait = "0.1"
aws-sdk-s3 = "0.17"
aws-sdk-s3 = "0.19"
aws-smithy-async = { version = "0.49.0", features = ["rt-tokio"] }
bytes = "1"
chrono = "0.4.19"
chrono-humanize = "0.2.2"
Expand Down
4 changes: 4 additions & 0 deletions server/src/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ use aws_sdk_s3::error::{HeadBucketError, HeadBucketErrorKind};
use aws_sdk_s3::model::{CommonPrefix, Delete, ObjectIdentifier};
use aws_sdk_s3::types::{ByteStream, SdkError};
use aws_sdk_s3::Error as AwsSdkError;
use aws_sdk_s3::RetryConfig;
use aws_sdk_s3::{Client, Credentials, Endpoint, Region};
use aws_smithy_async::rt::sleep::default_async_sleep;
use bytes::Bytes;
use crossterm::style::Stylize;
use datafusion::arrow::datatypes::Schema;
Expand Down Expand Up @@ -171,6 +173,8 @@ impl S3 {
.region(options.region)
.endpoint_resolver(options.endpoint)
.credentials_provider(options.creds)
.retry_config(RetryConfig::standard().with_max_attempts(5))
.sleep_impl(default_async_sleep().expect("sleep impl is provided for tokio rt"))
.build();

let client = Client::from_conf(config);
Expand Down