Skip to content

update list filters to support save view in prism #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

update list filters to support save view in prism #1343

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f70f6ff
update list filters to support save view in prism
nikhilsinhaparseable Jun 11, 2025
7bce091
update comments
nikhilsinhaparseable Jun 11, 2025
2ec90d7
refactor
nikhilsinhaparseable Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/users/filters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,25 +180,19 @@ impl Filters {
let read = self.0.read().await;

let mut filters = Vec::new();

let permissions = Users.get_permissions(key);
for f in read.iter() {
let query = if let Some(q) = &f.query.filter_query {
q
} else {
continue;
};
let query: &str = f.query.filter_query.as_deref().unwrap_or("");
let filter_type = &f.query.filter_type;

// if filter type is one of SQL or filter
// then check if the user has access to the dataset based on the query string
// if filter type is search then check if the user has access to the dataset based on the dataset name
if *filter_type == FilterType::SQL || *filter_type == FilterType::Filter {
// if filter type is SQL, check if the user has access to the dataset based on the query string
// if filter type is search or filter, check if the user has access to the dataset based on the dataset name
if *filter_type == FilterType::SQL {
if (user_auth_for_query(key, query).await).is_ok() {
filters.push(f.clone())
}
} else if *filter_type == FilterType::Search {
} else if *filter_type == FilterType::Search || *filter_type == FilterType::Filter {
let dataset_name = &f.stream_name;
let permissions = Users.get_permissions(key);
if user_auth_for_datasets(&permissions, &[dataset_name.to_string()]).is_ok() {
filters.push(f.clone())
}
Expand Down
Loading