Skip to content

refactor: associate conversion with STAGING, not storage #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2025
Merged

refactor: associate conversion with STAGING, not storage #1176

merged 3 commits into from
Feb 11, 2025

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Feb 9, 2025

Fixes #XXXX.

Description

Currently the code for sync reads a bit weird, conversion is a step not associated with ObjectStorage and hence should be related to STAGING

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh requested a review from parmesant February 9, 2025 15:08
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 70ca2f0 into parseablehq:main Feb 11, 2025
11 of 13 checks passed
@de-sh de-sh deleted the conversion branch February 11, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

@parmesant parmesant Awaiting requested review from parmesant

Assignees

No one assigned

Labels

for next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@de-sh @nikhilsinhaparseable @nitisht