Skip to content

chore: remove unused code #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2025
Merged

chore: remove unused code #1134

merged 2 commits into from
Jan 25, 2025

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 24, 2025 •
edited
Loading

Fixes #XXXX.

Description

This code is not used in any build, and is a remnant of the past

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12950684068

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.786%
Totals Coverage Status
Change from base Build 12949700124: 0.0%
Covered Lines: 2446
Relevant Lines: 19131
💛 - Coveralls

@nitisht nitisht merged commit 1c001c8 into parseablehq:main Jan 25, 2025
11 checks passed
@de-sh de-sh deleted the cleanup branch February 16, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhilsinhaparseable nikhilsinhaparseable Awaiting requested review from nikhilsinhaparseable

1 more reviewer

@parmesant parmesant parmesant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

for next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@de-sh @coveralls @parmesant @nitisht